#Adam.Blog# » Dumbass http://blog.adampresley.com I'm bringin' nerdy back. Fri, 03 Sep 2010 15:59:26 +0000 en hourly 1 http://wordpress.org/?v=3.0.1 Dumbass Code of the Day – 10/08/2009 http://blog.adampresley.com/2009/dumbass-code-of-the-day-10082009/ http://blog.adampresley.com/2009/dumbass-code-of-the-day-10082009/#comments Thu, 08 Oct 2009 22:55:17 +0000 Adam Presley http://blog.adampresley.com/?p=605
  • Dumbass Code of the Week – 10/05/2009
    • ]]>     Welcome to another edition of “Dumbass Code”. Here’s a snippet that’s fun. This bit of code gets a list of product IDs, iterates over them, and if the product ID is greater than zero, and less than 999,999 then it is a “special” type of product and is not counted. In this case a “special” product is a shipping record, or handling, etc… And “not counted” is done by using the listRest ColdFusion method to remove an item. I hadn’t even HEARD of this method till now, and it turns out that it just removes the first element from a list. Okaaaayyy…

    1
2
3
4
5
6
7
8
9
10
11

    <!-- this gets a count of actual products -->
<cfset prodlist = ValueList(getProds.product_id) >
<cfif listlen(prodlist) gt 0>
	<cfloop index="thisprodid" list="#prodlist#">
		<cfif 999999 lt evaluate(thisprodid) or evaluate(thisprodid) lt 0 >
			<cfset prodlist = listrest(prodlist)>
		</cfif>
	</cfloop>
</cfif>
 
<cfset numprods = listlen(prodlist)>

    Kind of odd eh? Seems like a lot of unnecessary processing to just get a count. How about something like this?

    1
2
3
4
5
6
7
8

    <!--- Get a count of actual products --->
<cfset numProducts = 0 />
 
<cfloop query="getProds">
	<cfif getProds.product_id GT 0 && getProds.product_id LT 999999>
		<cfset numProducts++ />
	</cfif>
</cfloop>

    Hmmm.

    Related posts:

    1. Dumbass Code of the Week – 10/05/2009

    ]]>     http://blog.adampresley.com/2009/dumbass-code-of-the-day-10082009/feed/ 3     Dumbass Code of the Week – 10/05/2009 http://blog.adampresley.com/2009/dumbass-code-of-the-week-10052009/ http://blog.adampresley.com/2009/dumbass-code-of-the-week-10052009/#comments Mon, 05 Oct 2009 22:06:19 +0000 Adam Presley http://blog.adampresley.com/?p=601
  • Dumbass Code of the Day – 10/08/2009
    • ]]>     Today’s Dumbass Code of the Week is brought to you by code from my current job. This code, written circa 2002, is real, and has not been modified or harmed in any way during the posting of this blog entry. Are you ready for it??

    1
2
3
4
5
6
7
8
9
10
11
12
13

    	<cfif Find("@", attributes.sEmail) GT 0>
		<cfif Find(".", attributes.sEmail, Find("@", attributes.sEmail)) GT Find("@", attributes.sEmail)>
			<!--- Set the Message the user will see if the process does not succed. --->
			<cfset UserMessage = "<p>A password could not be found for the email address #attributes.sEmail#.</p>">
		<cfelse>
 
			<cfset attributes.sEmail = "Invalid Email Address">
			<cfset UserMessage = "<p>Invalid Email Address.</p>">
		</cfif>
	<cfelse>
		<cfset attributes.sEmail = "Invalid Email Address">
		<cfset UserMessage = "<p>Invalid Email Address.</p>">
	</cfif>

    Take a good long look at it. What will the outcome of this “Lost Password” functionality be? Mmmmm, tasty.

    Related posts:

    1. Dumbass Code of the Day – 10/08/2009

    ]]>     http://blog.adampresley.com/2009/dumbass-code-of-the-week-10052009/feed/ 0